Fix font face keyboard selection crash#20255
Open
danyalahmed1995 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a crash in the Settings UI font face control when selecting a font suggestion with the keyboard and pressing Enter.
The font face
AutoSuggestBoxpath was explicitly unfocusing the box after a chosen suggestion was submitted. During the keyboard suggestion commit path, thatFocus(FocusState::Unfocused)call can trigger a WinUI/XAML crash before the settings model update completes.This change avoids explicitly unfocusing the
AutoSuggestBoxin the chosen-suggestion path and instead commits the selected font and moves focus to the parent container.Fixes #20245.
Validation
Manually validated with a local
CascadiaPackageDebug x64 build:Also checked: