-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Fix conhost.exe detect os version #2059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@miniksa do you know whether the windows inbox build automatically stamps us with the right sort of manifest, or if we need to make sure this change works over there as well? I'm all for it. This is great, and it moves our comctl dependency out of our project file 😄 |
|
Wait, the conhost.exe on my 18362 machine has two manifests. That can't be right ??? |
The Windows build automagically stamps us with a lot of manifest stuff. We cannot take this change until we ensure that it won't screw up the Windows build when this integrates back. |
|
OK @fcharlie, I've got two potential solutions for you here to unblock this so I'd feel OK taking it:
Or even better... Do both! |
DHowett-MSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
|
Sorry, I missed the close button on my phone |
* add openconsole.exe.manifest to fix detecting of os version
* add openconsole.exe.manifest to fix detecting of os version
Summary of the Pull Request
This PR is mainly to fix the conhost.exe not using the application manifest correctly and the operating system version cannot be detected correctly. Related documents can be viewed #2053.
This update also brings support for longPath to conhost.exe.
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
When DirectWrite rendering is turned on with
UseDx, this application cannot display emoji on Windows 10 before applying this PR. After applying this PR, it can be displayed normally.