Skip to content

Conversation

@shanselman
Copy link
Member

The Readme doesn't mention the store link until HALFWAY DOWN. The CTA here is to get the terminal.

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jul 23, 2019
@zadjii-msft
Copy link
Member

I'd also probably not make the tldr a top-level header, or put it above literally everything else. I'd maybe nest it under the "Windows Terminal" header that's on line 24. But hey I'm not a PM, @bitcrazed and @cinnamon-msft are.

@cinnamon-msft
Copy link
Contributor

I agree with @zadjii-msft. I would prefer a store link right above the Build Status with just a Microsoft Store Download header. Also, we may want to reference the Releases page in case the Store isn't an ideal option 😊

@miniksa
Copy link
Member

miniksa commented Jul 23, 2019

I agree with @zadjii-msft Mike Griese FTE. I would prefer a store link right above the Build Status with just a Microsoft Store Download header. Also, we may want to reference the Releases page in case the Store isn't an ideal option 😊

It looks like we have a store badge generator here (https://developer.microsoft.com/en-us/store/badges) that makes things like:

English badge

or maybe

Windows Terminal (Preview)

Microsoft Corporation

See price in store

SEE IN STORE
<script src="https://storebadge.azureedge.net/src/badge-1.8.3.js"></script> <script> mspb('9N0DX20HK701', function(badge) { document.getElementById('mspb-c1c3rvglogsd').innerHTML = badge; }); </script>

@zadjii-msft
Copy link
Member

selects the "JavaScript enabled = No" option
store still generates a Javascript badge

Speeling.

Co-Authored-By: Mike Griese <migrie@microsoft.com>
@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jul 23, 2019
Added store badge and reader and alternate release suggestion
@shanselman
Copy link
Member Author

Updated with all these suggestions.

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I'm much happier with this.

@miniksa miniksa merged commit e662277 into microsoft:master Jul 24, 2019
@shanselman shanselman deleted the patch-1 branch July 25, 2019 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants