Skip to content

Conversation

@zadjii-msft
Copy link
Member

Summary of the Pull Request

For some reason the NavigateUri property on the Hyperlinks in the about dialog don't work. This is a workaround for that bug. Instead of using NavigateUri, I'm just using a Click handler to do the same thing.

PR Checklist

@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Jul 25, 2019
@zadjii-msft zadjii-msft requested review from a team and cinnamon-msft July 25, 2019 18:07
@ghost ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jul 25, 2019
@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jul 26, 2019
@ghost
Copy link

ghost commented Jul 26, 2019

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@zadjii-msft
Copy link
Member Author

@msftbot wait 1 hour before merging this pr

@ghost
Copy link

ghost commented Jul 26, 2019

Hello @zadjii-msft!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Fri, 26 Jul 2019 17:40:19 GMT, which is in 1 hour

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@zadjii-msft
Copy link
Member Author

@msftbot don't merge this pr

@ghost
Copy link

ghost commented Jul 26, 2019

Hello @zadjii-msft!

I think you told me that you want to delay the approval for a certain amount of time, but I am not confident that I have understood you correctly.

Please try rephrasing your instruction to me.

@zadjii-msft zadjii-msft removed the AutoMerge Marked for automatic merge by the bot when requirements are met label Jul 26, 2019
@zadjii-msft
Copy link
Member Author

@msftbot please don't merge this PR until july 1st, 2030

@ghost
Copy link

ghost commented Jul 26, 2019

Hello @zadjii-msft!

I think you told me that you want to delay the approval for a certain amount of time, but I am not confident that I have understood you correctly.

Please try rephrasing your instruction to me.

@zadjii-msft
Copy link
Member Author

@msftbot forget everything I've told you

@zadjii-msft
Copy link
Member Author

This is straight up the wrong fix. Looks like sometimes the dialog won't auto-crash the app. Sometimes it will. I'll experiment more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash on About dialog when running Terminal unpackaged

5 participants