-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Fix #2078 by removing the NavigateUri's from the hyperlinks #2105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
@msftbot wait 1 hour before merging this pr |
|
Hello @zadjii-msft! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
|
@msftbot don't merge this pr |
|
Hello @zadjii-msft! I think you told me that you want to delay the approval for a certain amount of time, but I am not confident that I have understood you correctly. Please try rephrasing your instruction to me. |
|
@msftbot please don't merge this PR until july 1st, 2030 |
|
Hello @zadjii-msft! I think you told me that you want to delay the approval for a certain amount of time, but I am not confident that I have understood you correctly. Please try rephrasing your instruction to me. |
|
@msftbot forget everything I've told you |
|
This is straight up the wrong fix. Looks like sometimes the dialog won't auto-crash the app. Sometimes it will. I'll experiment more. |
Summary of the Pull Request
For some reason the NavigateUri property on the Hyperlinks in the about dialog don't work. This is a workaround for that bug. Instead of using NavigateUri, I'm just using a Click handler to do the same thing.
PR Checklist