Skip to content

Conversation

@alphapuggle
Copy link
Contributor

Finally this time maybe? I think I got it right.

Summary of the Pull Request

References

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Finally this time maybe? I think I got it right.
@DHowett-MSFT
Copy link
Contributor

First off, hold up a bit. You don’t need to make a new pull request for every change to the same line of documentation :) you can update existing pull requests probably more easily! This is just general advice going forward, because there might be comments on this one that need addressing!

@alphapuggle
Copy link
Contributor Author

alphapuggle commented Aug 12, 2019

Sorry, kind of new to the public github thing
Do I just commit to my forked repository to update the pull request?

@carlos-zamora
Copy link
Member

Sorry, kind of new to the public github thing
Do I just commit to my forked repository to update the pull request?

Don't worry about it :) Just git commit any changes you want then git push to update the pull request.

Co-Authored-By: Dustin L. Howett (MSFT) <duhowett@microsoft.com>
Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@DHowett-MSFT DHowett-MSFT merged commit d1a3e6d into microsoft:master Aug 21, 2019
@alphapuggle alphapuggle deleted the patch-1 branch August 21, 2019 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants