Skip to content

Conversation

@GageAmes
Copy link
Member

Summary of the Pull Request

The profiles.json file was moved from RoamingState to LocalState in PR #2298. This PR updates the documentation to reflect this change.

References

PR #2298

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

I searched through the documentation for references to RoamingState in relation to profiles.json and changed RoamingState to LocalState for such instances. The configuration example for adding a custom background could technically continue to reference the roaming path, but I felt it was best to change it to the local path since it referenced this path as the "same directory as your profiles.json file."

Validation Steps Performed

Documentation update only, so no validation was performed.

The profiles.json file was moved from RoamingState to LocalState in
PR microsoft#2298. Update the documentation to reflect this change.
Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@carlos-zamora
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@carlos-zamora carlos-zamora merged commit b096a57 into microsoft:master Sep 23, 2019
@GageAmes GageAmes deleted the localstate-doc-update branch September 24, 2019 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants