fix some typo. #2850
Closed
fix some typo. #2850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlos-zamora
requested changes
Sep 23, 2019
Member
carlos-zamora
left a comment
carlos-zamora
left a comment
There was a problem hiding this comment.
Assuming the whitespace changes were accidental, could you revert changes to doc/cascadia/Keybindings-spec.md? Other than that, looks good.
miniksa
requested changes
Sep 23, 2019
| ## Abstract | ||
| It should be possible to configure the terminal so that it doesn't send certain keystrokes as input to the terminal, and instead triggers certain actions. Examples of these actions could be copy/pasting text, opening a new tab, or changing the font size. | ||
|
|
||
| This spec describes a mechanism by which we could provide a common implementation of handling keyboard shortcuts like these. This common implementation could then be leveraged and extended by the UX implementation as to handle certain callbacks in the UX layer. For example, The TerminalCore doesn't have a concept of what a tab is, but the keymap abstraction could raise an event such that a WPF app could implement creating a new tab in its idomatic way, and UWP could implement them in their own way. |
Member
There was a problem hiding this comment.
Your merge appears to have flattened this fix.
Suggested change
| This spec describes a mechanism by which we could provide a common implementation of handling keyboard shortcuts like these. This common implementation could then be leveraged and extended by the UX implementation as to handle certain callbacks in the UX layer. For example, The TerminalCore doesn't have a concept of what a tab is, but the keymap abstraction could raise an event such that a WPF app could implement creating a new tab in its idomatic way, and UWP could implement them in their own way. | |
| This spec describes a mechanism by which we could provide a common implementation of handling keyboard shortcuts like these. This common implementation could then be leveraged and extended by the UX implementation as to handle certain callbacks in the UX layer. For example, The TerminalCore doesn't have a concept of what a tab is, but the keymap abstraction could raise an event such that a WPF app could implement creating a new tab in its idiomatic way, and UWP could implement them in their own way. |
doc/building.md
Outdated
| - Release | ||
| - AuditMode | ||
|
|
||
| AuditMode is an experimental mode that enables some additional static analyis from CppCoreCheck. |
Member
There was a problem hiding this comment.
You appear to have lost this one with the merge too.
doc/submitting_code.md
Outdated
| 1. make sure you have pulled the latest commits for the `dev/main` and `inbox` branches | ||
| 2. make a new branch from inbox | ||
| 3. cherry-pick the commits from the PR to the newly created branch (this is easier if you squashed your commits when you merged into `dev/main` | ||
| 4. fix any merge conficts and commit |
Member
There was a problem hiding this comment.
This file's changes also look lost on merge.
miniksa
requested changes
Sep 23, 2019
Contributor
Author
|
Contributor
Author
|
@carlos-zamora @miniksa , yes, i will raise another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just fix some typos in docs.
References
N/A
PR Checklist
Tests added/passedRequires documentation to be updatedDetailed Description of the Pull Request / Additional comments
just fix some typo in documentations
Validation Steps Performed