conhost: if we start with invalid terminal colors, reset them to sanity #2855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've seen a number of cases where the user's settings can get corrupted and their default foreground/background and cursor color get set to all black (black on black). This results in a fairly unhappy user and probably a great number of support incidents. Let's declare that an invalid state.
miniksa
reviewed
Sep 23, 2019
miniksa
reviewed
Sep 23, 2019
DHowett-MSFT
commented
Sep 23, 2019
DHowett-MSFT
commented
Sep 23, 2019
carlos-zamora
approved these changes
Sep 23, 2019
Contributor
Author
|
@miniksa i need a second on this |
miniksa
approved these changes
Sep 24, 2019
DHowett-MSFT
pushed a commit
that referenced
this pull request
Sep 26, 2019
…ty (#2855) * conhost: if we start with invalid terminal colors, reset them to sanity We've seen a number of cases where the user's settings can get corrupted and their default foreground/background and cursor color get set to all black (black on black). This results in a fairly unhappy user and probably a great number of support incidents. Let's declare that an invalid state. * Add some comments to the comments (cherry picked from commit a1bd796)
|
This merge claims to have fixed something, but I still see it broken: |
Contributor
Author
|
Are you using a version of Windows that was released after this was merged? I’m going to guess you’re not, because it’s only available to Insiders right now. |
Contributor
Author
|
Anyway, to fix it: go to the Terminal tab and turn off all the extra color settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen a number of cases where the user's settings can get corrupted
and their default foreground/background and cursor color get set to all
black (black on black). This results in a fairly unhappy user and
probably a great number of support incidents.
Let's declare that an invalid state.
Related to #2651.