Edits doc section: Starting Windows Terminal #2998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
martin389
commented
Sep 30, 2019
martin389
commented
- Proposes using the search function to locate the app.
- Restructures as a procedure.
- Adds misc edits.
* Proposes using the search function to locate the app. * Restructures as a procedure. * Adds misc edits.
zadjii-msft
reviewed
Sep 30, 2019
Member
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
What about launching it from just scrolling to "Windows Terminal (Preview)"?
That seems like a scenario that's kind of lost in this change. I think I'd prefer a bit more generic text here.
Contributor
Author
I do personally prefer the scrolling approach, rather than search. The reasoning for using search was seeing how it seems to be favoured in other documentation. I'll update the draft to be more generic about this. |
Made step 1 more generic, rather than prescribing the search method.
zadjii-msft
added
the
Issue-Docs
bitcrazed
reviewed
Oct 1, 2019
Contributor
bitcrazed
left a comment
bitcrazed
left a comment
There was a problem hiding this comment.
Added a small suggestion, but otherwise, LGTM.
miniksa
approved these changes
Oct 3, 2019
cinnamon-msft
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.