Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Nov 1, 2019

Summary of the Pull Request

Adds a blinking cursor to the WPF terminal control

Validation Steps Performed

VS terminal was patched with new bits to verify cursor only blinked when it had keyboard focus.

@ghost ghost requested a review from javierdlg November 1, 2019 22:59
Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't expect there's an answer to this that helps y'all ship sooner, but is there an architectural improvement we could take on that would make it so you don't need a p/invoke down into C++ just to tell the cursor to blink? 😄

(request changes is for the method names alone.)

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Nov 3, 2019
@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Nov 4, 2019
@ghost
Copy link
Author

ghost commented Nov 4, 2019

I don't expect there's an answer to this that helps y'all ship sooner, but is there an architectural improvement we could take on that would make it so you don't need a p/invoke down into C++ just to tell the cursor to blink? 😄

(request changes is for the method names alone.)

Registration-free COM might work, but I'm not an expert on how to set that up. We at least need some of the blink handling happening in the managed code since that has access to the dispatcher timer.

@ghost ghost requested a review from DHowett-MSFT November 4, 2019 20:40
@DHowett-MSFT DHowett-MSFT changed the title make the cursor blink in the wpf control wpf: make the cursor blink Nov 4, 2019
@DHowett-MSFT DHowett-MSFT merged commit 6f36f8b into master Nov 4, 2019
@DHowett-MSFT DHowett-MSFT deleted the dev/zorio/wpf-blinking-cursor branch November 4, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants