Skip to content

Conversation

@TheBrain0110
Copy link
Contributor

@TheBrain0110 TheBrain0110 commented Nov 12, 2019

Summary of the Pull Request

A simple one-liner addition to profiles.schema.json.

Enables VSCode to recognize Color-type entries in profiles.json and show a color decorator in the editor.

"format" : "color" is a nonstandard, VSCode-specific extension to the schema format, but it shouldn't hurt validation for this case.

PR Checklist

  • Closes schema: add support for Visual Studio Code color picker #3287
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Validation Steps Performed

Tested manually.

To enable VS Code to recognize them and show a color decorator in the editor
@DHowett-MSFT
Copy link
Contributor

If this schema extension causes VScode to emit an alpha channel, it will be incompatible with the Terminal’s actual schema

@TheBrain0110
Copy link
Contributor Author

I just tested locally, and while you can use VSCode's color picker to set an alpha value, it gets marked with a warning as being incompatible with the defined schema. So it shouldn't cause any real issues, the warning is right there in the editor.

@zadjii-msft zadjii-msft added Area-Schema Things that have to do with the json schema. Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs labels Nov 12, 2019
Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great to me

Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!!

@carlos-zamora
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@carlos-zamora carlos-zamora merged commit 6dec0b6 into microsoft:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Schema Things that have to do with the json schema. Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

schema: add support for Visual Studio Code color picker

4 participants