Skip to content

Conversation

@JennyMLee
Copy link

Summary of the Pull Request

References

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

cinnamon-msft and others added 8 commits July 24, 2019 13:07
KeybindingSettingsContent can be constructed with ptr to settings.
Removed icons and moving the tooltip  to the action instead
Function now accepts a argument which will be usd to return the correct keybind from the backend
@msftclas
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ JennyMLee sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@JennyMLee JennyMLee closed this Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants