Don't report scheme parse errors by default #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devhawk
changed the title
miniksa
added
the
Product-Colortool
miniksa
reviewed
Feb 27, 2019
Member
|
@DHowett-MSFT, @zadjii-msft, can one of you be second reviewer? |
DHowett-MSFT
approved these changes
Feb 27, 2019
Contributor
DHowett-MSFT
left a comment
DHowett-MSFT
left a comment
There was a problem hiding this comment.
I think this could benefit from a general overhaul. Error suppression or reporting should be the responsibility of the callers of ParseScheme, but I think this is an acceptable low-risk quality of life fix as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ColorTool now has three different color scheme parsers (.ini files, concfg JSON files and itermcolors XML files). Because each scheme parser is tried in turn until one succeeds, any scheme parser that fails dumps useless error information to the console.
This change flips the
reportErrorsparameter ofISchemeParser.ParseSchemefrom true to false so these failed parse error messages are not printed by default. This PR also adds a new--errorsor-ecommand line argument to enable error reporting for usage scenarios that need it.