Epic: Search v2

[KaiyuWang16]

Description of the new feature/enhancement

[Original Issue: #605] [Original Spec: #3299] [Initial PR: #3590]

Terminal text search has already realizes single tab case sensitive/insensitive forward/backward search. In phase 2, we are considering these new features:

• Add "Find" button in dropdown menu to trigger search. Now the search dialog is launched by key bindings, we may need to consider binding the dialog to a button in dropdown menu for mouse only operations.
  • sorta in Add find item to tab menu #13055. Close enough.
• High-light while you type. Emphasizing all the matches in the buffer with an outline or selection with another color. This provides a clearer view of the searched text.
  • Feature Request: Highlight all finding #7561 Feature Request: Highlight all finding
• Search should display the number of results it finds #6319 No results notification (or reveal number of results)
  • in Show number of search results & positions of hits in scrollbar #14045
• Please add "next search match" and "prev search match" bind-able key for find operations #7695 next/previous search key bindings
• Selected text should populate search box #8307 Selected text should populate search box
• Search behavior in Terminal -- add capability to insert the matched hit #8274 Add capability to insert matched hit
• FR: IDE-style marks on scrollbar #1527 Display "find" matches in the scrollbar, Display "find" matches in the scrollbar  #8631
  • in Show number of search results & positions of hits in scrollbar #14045
• Pressing next/previous match keybindings should move to the next needle, even if the dialog is closed. (Maybe it should auto display the dialog)
  • Mentioned in Add NextSearchMatch and PreviouSearchMatch actions #8522 and Introduce search status #8588
• It'd be cool if there was a shadow underneath the search dialog, like there is for the command palette.
  • Mentioned in Search box visual tweaks #11105 (comment)
  • Fixed in Command palette and search box visual tweaks #12913
• Regular expression (regex) match. This is a useful search pattern and is implemented in some editors.
  • first proto in Allow regex search #9228
  • Will be effortless after Use ICU for text search #15858 merges
  • merged in Add support for regex search to conhost and Terminal #17316, in 1.22
• Add size handle. Some text editors let the user resize the search box, and there is a size handle on the left side of the search box. This helps user when they search for long text.
• Feature Request: Fuzzy Search #5314 Fuzzy Search
  • Go look at Fuzzy Search #16586
• Don't let results hide under search box #4407
• Search from all tabs. In phase one search are limited within one Terminal window. However, the community also requests search from all tabs. This may require a big change to the search algorithm.
  • Depends on A pane doesn't necessarily need to host a terminal. #997 by all accounts
• Search history. Sometimes users would do the same search for several times, thus, storing the search history is useful.

Also related, from #5001:

• Add a setting to configure the regex used to detect patterns
• Allow "hyperlink" matching for arbitrary patterns and adding custom handlers Allow "hyperlink" matching for arbitrary patterns and adding custom handlers  #8849
  • Theoretically, this could supersede [DISCUSSION] Allow more URI schemes #7562
  • Should be self-consistent with Add a setting to configure display of auto detected links, normally and on hover #8294
• Control the styling of hyperlinks - attributes used for autodetected hyperlinks, and then different attributes for hovered ones Add a setting to configure display of auto detected links, normally and on hover #8294

[wenmin92]

Also need search result count.