Skip to content

Conversation

@LokiMidgard
Copy link
Contributor

This is an proposal to store background and foreground color index.

I've added two section screen and popup. Both sections contain two keys FORGROUND and BACKGROUND. The assignable values are keys of the table section.

sample

[table]
DARK_BLACK = 12,12,12
DARK_BLUE = 0,55,218
DARK_GREEN = 19,161,14
DARK_CYAN = 58,150,221
DARK_RED = 197,15,31
DARK_MAGENTA = 1,36,86
DARK_YELLOW = 238,237,240
DARK_WHITE = 204,204,204
BRIGHT_BLACK = 118,118,118
BRIGHT_BLUE = 59,120,255
BRIGHT_GREEN = 22,198,12
BRIGHT_CYAN = 97,214,214
BRIGHT_RED = 231,72,86
BRIGHT_MAGENTA = 180,0,158
BRIGHT_YELLOW = 249,241,165
BRIGHT_WHITE = 242,242,242

[screen]
FOREGROUND = DARK_YELLOW
BACKGROUND = DARK_MAGENTA

[popup]
FOREGROUND = DARK_CYAN
BACKGROUND = BRIGHT_WHITE

[info]
name = powershell-default

@miniksa miniksa requested a review from zadjii-msft April 1, 2019 15:55
@miniksa miniksa added the Product-Colortool This is a problem with the utility application ColorTool for manipulating the console color palette. label Apr 1, 2019
@miniksa miniksa self-requested a review April 1, 2019 15:57
@zadjii-msft
Copy link
Member

I'm okay with this for the time being.

Ideally, I'd want to also have a way to export the "terminal" default foreground and background colors, but since those aren't really query-able, nor set-able with VT, then it doesn't really make sense to include them in the scheme currently. We can come back and add support to colortool for those later, once the support is there in the console itself.

@LokiMidgard
Copy link
Contributor Author

I think I got all "forground". I also added the popup attributes to the JsonParser

Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@miniksa miniksa merged commit 619a80e into microsoft:master Apr 2, 2019
@LokiMidgard LokiMidgard deleted the back-and-forground-index-export branch April 2, 2019 17:22
@WSLUser WSLUser mentioned this pull request Jun 2, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Product-Colortool This is a problem with the utility application ColorTool for manipulating the console color palette.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants