schema: add support for "auto" split value #4249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
carlos-zamora
left a comment
carlos-zamora
left a comment
There was a problem hiding this comment.
I'd be all for auto being the default value :)
doc/cascadia/profiles.schema.json
Outdated
| "$ref": "#/definitions/SplitState", | ||
| "default": "vertical", | ||
| "description": "The orientation to split the pane in, either vertical (think [|]) or horizontal (think [-])" | ||
| "description": "The orientation to split the pane in, either vertical (think [|]), horizontal (think [-]), or auto" |
Member
There was a problem hiding this comment.
Could you describe auto in the description too?
Member
|
Related to #4025 |
Contributor
Author
|
Added the requested changes |
DHowett-MSFT
approved these changes
Jan 15, 2020
zadjii-msft
approved these changes
Jan 15, 2020
Member
|
Thanks for updating this! This is totally on me for not doing that in the first place 😝 |
DHowett-MSFT
changed the title
Contributor
Author
|
No problem! 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
profiles.schema.jsondid not haveautoas a valid value for thesplitattribute. This PR adds the support and makes a minor update to the details associated with thesplitattribute.References
PR Checklist
Detailed Description of the Pull Request / Additional comments
Potentially the
defaultvalue forSplitPaneActionshould be set toautoas well. Let me know your thoughts.Validation Steps Performed
Changed the
$schemaattribute in my localprofiles.jsonto the updatedprofiles.schema.jsonand ensured thatautodid not have a squiggly line like in #4245.