Allow string values (like "system") in the rowsToScroll schema
#4342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
In #3575, Terminal added support for the
rowsToScrollfield – which accepts integers or"system". However, the settings schema only allows integers:terminal/doc/cascadia/profiles.schema.json
Lines 289 to 295 in e675de3
which means writing
rowsToScroll: "system"produces the following warning:This PR fixes the issue.
PR Checklist
Validation Steps Performed
$schemafield with the updated schema from my fork (https://raw.githubusercontent.com/iamakulov/terminal/b5d4c9337d3f323613dd5209bb68decb86cce667/doc/cascadia/profiles.schema.json)."system"value doesn’t produce the warning anymorefalse(i.e., a boolean – a type that’s not accepted) still produces a warning