Add explicit to bool operators of Point and Rect

[carlos-zamora]

Found a bug where the following won't work:

COORD inclusiveEnd{ _end };

where _end is a til::point.

The only fix for this is to replace these instances with this:

COORD inclusiveEnd = _end;

What was happening in the first notation is the implicit conversion of til::point to bool to SHORT. The constructor for COORD only sees one SHORT so it thinks the value should be the definition for X, and Y should stay as 0. So we end up getting 1, 0.

By adding the explicit keyword to the bool operators, we prevent the accident above from occurring.

[miniksa]

Did you forget the one on size.h or did I not put one there?

[carlos-zamora]

Did you forget the one on size.h or did I not put one there?

surprisingly, there isn't one there. Want me to add one in?

[miniksa]

Did you forget the one on size.h or did I not put one there?

surprisingly, there isn't one there. Want me to add one in?

Eh, only if you need it.

[miniksa]

Did you forget the one on size.h or did I not put one there?

surprisingly, there isn't one there. Want me to add one in?

Eh, only if you need it.

Or whatever, I see you already did. It's fine.

[zadjii-msft]

Wait could we add a test for the case you explicitly put in the description?

[carlos-zamora]

Wait could we add a test for the case you explicitly put in the description?

Doing something like this:

        const til::point pt{ 1, 1 };
        COORD cd{ pt };

won't even compile. So, I think there isn't a way we can test it.

[zadjii-msft]

Oh well that'll do for me, thanks!

[ghost]

Hello @miniksa!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.