Update reference to the current WT commandline #5164
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The index.md is outdate indicating there is not commandline options but since versio XXXX there. And some are docummented in UsingCommandlineArguments.md. I also added reference to list to changes of the WT releases. I removed the line. "None at this time. See issue [microsoft#607](microsoft#607)"
jsoref
reviewed
Mar 30, 2020
|
|
||
| To compile Windows Terminal yourself using the source code, follow the instructions in the [README](/README.md#developer-guidance). | ||
|
|
||
| You check the WT [releases changes](https://github.com/microsoft/Terminal/releases). |
zadjii-msft
reviewed
Mar 30, 2020
Member
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
Couple nits here, though the team can overrule me.
|
|
||
| To compile Windows Terminal yourself using the source code, follow the instructions in the [README](/README.md#developer-guidance). | ||
|
|
||
| You check the WT [releases changes](https://github.com/microsoft/Terminal/releases). |
Member
There was a problem hiding this comment.
I'm not sure this line's totally necessary here. Kinda feels out of place here to me. At the very least, I'd reword it
Suggested change
| You check the WT [releases changes](https://github.com/microsoft/Terminal/releases). | |
| Please refer to the Windows Terminal [releases notes](https://github.com/microsoft/Terminal/releases) for the latest changes. |
zadjii-msft
added
Issue-Docs
zadjii-msft
added
the
Needs-Author-Feedback
Contributor
|
I agree with @zadjii-msft's recommendations. :) |
Co-Authored-By: Mike Griese <migrie@microsoft.com>
ghost
removed
the
Needs-Author-Feedback
Contributor
|
Hey, thanks for the docs contribution! We're going to be revisiting our user docs soon, and in the interest of reducing file conflicts we're not taking on changes at this exact moment. I'll be happy to have you back when we've cleared that hurdle 😄 |
Author
|
Hello Dustin. Thanks for the feedback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The index.md is outdate indicating there is not commandline options but since versio XXXX there. And some are docummented in UsingCommandlineArguments.md.
I also added reference to list to changes of the WT releases.
I removed the line. "None at this time. See issue #607"
Summary of the Pull Request
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed