Skip to content

Conversation

@jsoref
Copy link
Contributor

@jsoref jsoref commented Apr 19, 2020

Summary of the Pull Request

  • Cleaning up the whitelist a bit.

  • ⚠️ This check-spelling 0.0.15a+ tolerates Windows line endings in the whitelist.txt file (another project I touched had some .gitconfig magic which required supporting them).

    This means that if someone edits the file w/ something that likes Windows line endings, the file will successfully convert (instead of it being ignored and check-spelling complaining about everything). Most likely anyone else who then edits the file will use something that will maintain the line endings.

References

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for staying on top of this!

@jsoref jsoref changed the title ci/spelling: update whitelist ci: spelling: update to 0.0.15a; update whitelist Apr 21, 2020
@DHowett-MSFT DHowett-MSFT merged commit bc6ea11 into microsoft:master Apr 21, 2020
@DHowett-MSFT
Copy link
Contributor

Thanks!

@jsoref jsoref deleted the spelling branch April 21, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants