Skip to content

Add descriptions for backgroundImageAlignment, backgroundImageOpacity #5533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zadjii-msft merged 1 commit into from
Apr 24, 2020
Merged

Add descriptions for backgroundImageAlignment, backgroundImageOpacity #5533

zadjii-msft merged 1 commit into from
Apr 24, 2020

Conversation

@zadjii-msft
Copy link
Member

@zadjii-msft zadjii-msft commented Apr 24, 2020

These were already in the SettingsSchema.md, so I just updated the profiles.schema.json to have the descriptions as well.

@zadjii-msft zadjii-msft added Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. labels Apr 24, 2020
carlos-zamora
carlos-zamora approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: This will conflict with #5304 (but I'll just merge taking your changes over mine)

@zadjii-msft
Copy link
Member Author

zadjii-msft commented Apr 24, 2020

@carlos-zamora derp, I didn't realize that PR hadn't merged yet. my b.

@zadjii-msft zadjii-msft merged commit fa58d87 into master Apr 24, 2020
@zadjii-msft zadjii-msft deleted the dev/migrie/docs/5520-backgroundImageSchema branch April 24, 2020 17:15
DHowett-MSFT pushed a commit that referenced this pull request Apr 24, 2020
@zadjii-msft @DHowett
Add descriptions for backgroundImageAlignment, `backgroundImageOpac…
03613dc 
…ity` (#5533)

These were already in the `SettingsSchema.md`, so I just updated the `profiles.schema.json` to have the descriptions as well.

* [x] closes #5520
* [x] I work here.
* [x] This is docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@miniksa miniksa miniksa approved these changes

Assignees

No one assigned

Labels

Area-Settings Issues related to settings and customizability, for console or terminal Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Product-Terminal The new Windows Terminal.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't see some setting's description in settings.json

4 participants

@zadjii-msft @carlos-zamora @miniksa