Skip to content

Conversation

@skyline75489
Copy link
Collaborator

Summary of the Pull Request

The working fix, in case you needed it.

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Manually validated.

Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a quick and easy fix, but it's just hiding the problem. It shouldn't be possible to pull those state variables out from under the renderer while it is in the middle of a frame. That's an assumption the entire renderer makes. So we shouldn't fix this with just a null check as it'll just bounce around to somewhere else.

I'd rather we fix this with doing the correct locking per what @zadjii-msft mentioned in #5479.

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 27, 2020
@skyline75489
Copy link
Collaborator Author

Close this in favor of whatever @zadjii-msft will offer. I'm pretty sure it'll be good.

@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 28, 2020
@skyline75489 skyline75489 deleted the fix/font-size-crash-naive-fix branch January 25, 2021 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crashes if zoom font size up and down rapidly with ctrl + scroll wheel

2 participants