Skip to content

Conversation

@guest123guest
Copy link

I see the developers forgot to put in a "copyright" in a files. this fixes it on... razzle.cmd.

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is helpful, though if this file needs it, I'm assuming all the other .cmd files in the tools/ dir would also need this line.

@binarycrusader
Copy link
Member

This is helpful, though if this file needs it, I'm assuming all the other .cmd files in the tools/ dir would also need this line.

I think the standard copyright header doesn't usually include the year either, right?

Example:

// Copyright (c) Microsoft Corporation.
// Licensed under the MIT license.

@mkwilbux
Copy link

mkwilbux commented May 9, 2019

No copyright!!!!

@gpotter2
Copy link

gpotter2 commented May 9, 2019

mkwilbux commented about 16 hours ago

No copyright!!!!

D287B8AF-012D-4979-8EE9-2C19FA12F7EE

So it gives YOU permission. 😸
Also come on, an MIT license is super generous what else do you want ?

@miniksa
Copy link
Member

miniksa commented May 10, 2019

If this gets a banner, it at a minimum needs to match the pattern of the other banners like:

rem Copyright (c) Microsoft Corporation.
rem Licensed under the MIT license.

Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please match banner style to the other banners per my other comment.

@miniksa miniksa added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label May 18, 2019
@ghost
Copy link

ghost commented May 18, 2019

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@ghost ghost added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label May 18, 2019
rem Open Console build environment setup
rem Adds msbuild to your path, and adds the open\tools directory as well
rem This recreates what it's like to be an actual windows developer!
rem Copyright 2019 Microsoft
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are sure for copyright with the year? because each year it will be necessary to make a sweater request a little useless to increase this value..... :/

@ghost ghost removed the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label May 22, 2019
@ghost ghost added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label May 29, 2019
@ghost
Copy link

ghost commented May 29, 2019

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@dlong11
Copy link

dlong11 commented Jun 1, 2019

If a copyright is required when adding a file to the repo then we should include this in the docs. From the discussion and looking at the source it appears this is the correct one.
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT license.

This should be included in the docs.
#890

@ghost ghost removed the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Jun 1, 2019
@ghost ghost added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Jun 8, 2019
@ghost
Copy link

ghost commented Jun 8, 2019

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@ghost ghost removed the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Jun 9, 2019
@ghost ghost added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Jun 16, 2019
@ghost
Copy link

ghost commented Jun 16, 2019

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@ghost ghost closed this Jun 23, 2019
@guest123guest guest123guest deleted the patch-1 branch July 11, 2019 01:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants