-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Add in copyright #595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in copyright #595
Conversation
zadjii-msft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is helpful, though if this file needs it, I'm assuming all the other .cmd files in the tools/ dir would also need this line.
I think the standard copyright header doesn't usually include the year either, right? Example: // Copyright (c) Microsoft Corporation. |
|
No copyright!!!! |
|
If this gets a banner, it at a minimum needs to match the pattern of the other banners like: |
miniksa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please match banner style to the other banners per my other comment.
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. |
| rem Open Console build environment setup | ||
| rem Adds msbuild to your path, and adds the open\tools directory as well | ||
| rem This recreates what it's like to be an actual windows developer! | ||
| rem Copyright 2019 Microsoft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are sure for copyright with the year? because each year it will be necessary to make a sweater request a little useless to increase this value..... :/
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. |
|
If a copyright is required when adding a file to the repo then we should include this in the docs. From the discussion and looking at the source it appears this is the correct one. This should be included in the docs. |
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. |
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. |

I see the developers forgot to put in a "copyright" in a files. this fixes it on... razzle.cmd.