Add stdexcept header explicitly to u8u16test tool #6226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icitly included in STL 16.5 but no longer in STL 16.6.
miniksa
added
Area-Build
zadjii-msft
approved these changes
May 27, 2020
Member
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
Yours has a better description
DHowett
approved these changes
May 27, 2020
jelster
pushed a commit
to jelster/terminal
that referenced
this pull request
May 28, 2020
## Summary of the Pull Request Adds implicit stdexcept header include to u8u16test tool. ## PR Checklist * [x] Closes regression introduced when moving from VS 16.5 to VS 16.6 (which the CI did of its own accord) * [x] I work here. * [x] Built it. * [x] No doc. * [x] Am core contributor. ## Detailed Description of the Pull Request / Additional comments In VS 16.5, the <stdexcept> header was pulled in by `<string>` or `<string_view>` or `<array>` or `<algorithm>` implicitly. In VS 16.6, that's gone. No one wrote it in the header because it was just automatically there in the past. Now I wrote it in the header. ## Validation Steps Performed * [x] Built it on my machine after upgrading to VS `16.6.0`. * [x] Built it in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds implicit stdexcept header include to u8u16test tool.
PR Checklist
Detailed Description of the Pull Request / Additional comments
In VS 16.5, the header was pulled in by
<string>or<string_view>or<array>or<algorithm>implicitly. In VS 16.6, that's gone. No one wrote it in the header because it was just automatically there in the past. Now I wrote it in the header.Validation Steps Performed
16.6.0.