Skip to content

Conversation

@mottosso
Copy link

Hi all,

I'm having a look at building Terminal automatically on each tag or merged PR, so I could follow along and try things out without necessarily installing the build infrastructure.

The script works well so far, except it fails after about 8 minutes due to some issue I couldn't find mentioned in the issue section or in code.

  LINK : fatal error LNK1104: cannot open file 'atls.lib' [C:\projects\terminal\src\interactivity\win32\ut_interactivity_win32\Interactivity.Win32.UnitTests.vcxproj]

I suspect AppVeyor doesn't provide the necessary libraries from Windows 1903, in which case my next question would be whether there was anything I could install or add to AppVeyor during build so as to make it pass?

I found this for 1803, and figured maybe applying those lessons for 1903 would work here?

PS: Before merging, don't forget to update the GitHub personal access token.

@msftclas
Copy link

msftclas commented May 10, 2019

CLA assistant check
All CLA requirements met.

@miniksa
Copy link
Member

miniksa commented May 10, 2019

Do we need AppVeyor when we have Azure Pipelines set up here already?

Also atls.lib is old school ATL/MFC dependency which is probably not installed on the build machine.

@mottosso
Copy link
Author

Do we need AppVeyor when we have Azure Pipelines set up here already?

Probably not, I noticed Azure kicking in with this PR. Would make more sense getting that pipeline to push artifacts out directly I think.

@miniksa
Copy link
Member

miniksa commented May 10, 2019

I believe that it is on our agenda to make that happen, but we're not ready for it yet. @DHowett-MSFT is driving the timeframes and plans on that.

I think last time we discussed this, we feel like providing a binary straight up implies some sort of support commitment of those binaries that we're not necessarily ready to provide yet.

@mottosso mottosso closed this May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants