Skip to content

Improvements to TerminalInput #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adiviness merged 12 commits into from
May 30, 2019
Merged

Improvements to TerminalInput #690

adiviness merged 12 commits into from
May 30, 2019

Conversation

@Nicholas-Baron
Copy link
Contributor

@Nicholas-Baron Nicholas-Baron commented May 11, 2019

Modernization and light cleanup of TerminalInput.cpp and .hpp.

Addresses Issue #685

dlong11
dlong11 reviewed May 11, 2019
View reviewed changes
@jetersen
Copy link

jetersen commented May 11, 2019

@Nicholas-Baron
You might want to set up an email alias on your GitHub account 🥇
Or look into fixing your git user.email config 😅
to get proper credit for your commits 🏆
https://help.github.com/articles/adding-an-email-address-to-your-github-account/
https://help.github.com/articles/setting-your-commit-email-address-in-git
then to amend your commits: https://stackoverflow.com/a/3042512

You can see your email used here: https://github.com/microsoft/Terminal/pull/690/commits/bdb587dc359481c97961b776703e67f11bd6b94a.patch

zadjii-msft
zadjii-msft approved these changes May 13, 2019
View reviewed changes
@zadjii-msft zadjii-msft requested a review from adiviness May 13, 2019 14:10
adiviness
adiviness suggested changes May 13, 2019
View reviewed changes
miniksa
miniksa reviewed May 16, 2019
View reviewed changes
Nicholas Baron added 2 commits May 16, 2019 11:27
Removed extraneous newlines
6665feb
Deleted all move and copy operations.
480aa62 
The default constructor is also deleted.
The destructor is defaulted.
miniksa
miniksa requested changes May 21, 2019
View reviewed changes
@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label May 21, 2019
@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label May 21, 2019
DHowett-MSFT
DHowett-MSFT approved these changes May 30, 2019
View reviewed changes
Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me!

@adiviness adiviness merged commit dadd74c into microsoft:master May 30, 2019
@zadjii-msft zadjii-msft mentioned this pull request Jul 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@binarycrusader binarycrusader binarycrusader left review comments

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@miniksa miniksa miniksa approved these changes

+4 more reviewers

@dlong11 dlong11 dlong11 left review comments

@mKay00 mKay00 mKay00 left review comments

@adiviness adiviness adiviness approved these changes

@DHowett-MSFT DHowett-MSFT DHowett-MSFT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Nicholas-Baron @jetersen @binarycrusader @adiviness @dlong11 @DHowett-MSFT @miniksa @zadjii-msft @mKay00