-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Readability improvements. #7636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
New misspellings found, please review:
To accept these changes, run the following commands✏️ Contributor please read thisBy default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.
If the listed items are:
See the 🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The :check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉
|
|
Keep in mind, unless it's a spec or Roadmap most of the documentation has been moved to https://github.com/microsoftdocs/terminal |
|
Thanks for the answer, I replaced it with the old one. |
|
No doubt this is subjective, but I personally find the introduction of all those It seems to me that the amount of space to include before a heading should really be a stylistic choice for the renderer. Anyone that prefers more spacing could always use a different viewer, or adjust the css themselves. So I don't think it's appropriate to force a particular style on everyone by hacking in |
|
@mertcandav Thanks for the contribution! I'm inclined to agree with James on this one -- the spacing around the headings and the sections is something that should be handled on the client side... because there's a great number of different markdown renderers, with different rendering characteristics, I'm averse to introducing hard line breaks to serve just one of them. I personally find them noisy as well, as I tend to read the plaintext versions of the documents as that's how they pass around in our review cycles and live in our working trees. We can also ignore the entire user-docs/ folder. It's not long for this world. |
|
Thanks for the comments! |
Readability improvements for
./doc/Validation Steps Performed