[DRAFT] Try out a fun new build pool, II #7788
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WAP packaging project in VS <= 16.7.3 produces a global property as part of its normal operation that causes MSBuild to flag our projects as out-of-date and requiring a rebuild. By forcing this property to match the WAP values, we can get consistent builds. That property is "GenerateAppxPackageOnBuild", and WAP sets it to *false*. When we set that, of course, we don't get an MSIX out of our build pipeline. Therefore, we have to break our build into two phases -- build, then package. This is just like #3412, but a couple versions of VS in the future. If you want to read a pareto-identical commit message, go read that one.
This reverts commit 3ac5712.
(cherry picked from commit fd9106b)
Member
|
electric boogaloo |
Member
Author
|
11 min CI build on the x86 leg! x64 hit a UT hang unrelated to the new build agent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed