Fixed a bug where terminal won't build when local user folder has spaces #785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniksa
approved these changes
May 14, 2019
Member
miniksa
left a comment
miniksa
left a comment
There was a problem hiding this comment.
I know there's other outstanding issues/plans to replace xcopy with robocopy or something that doesn't have language/locale dependent flags. But this fix seems like goodness we can take now until that is done.
miniksa
added
the
Area-Build
Member
|
I was thinking of #741 specifically... |
Contributor
Author
Member
|
#741 is WIP, so I'm willing to take this in the interim. |
carlos-zamora
approved these changes
May 14, 2019
adiviness
approved these changes
May 14, 2019
ObsidianPhoenix
pushed a commit
to ObsidianPhoenix/Terminal
that referenced
this pull request
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added quotes to the commands that caused issues on my machine - Managed to build it and deploy with no issues.