Improve OSC 8 Hyperlink parsing logic

[skyline75489]

This PR improves the OSC 8 Hyperlink parsing logic, by adding support to
: in params.

Validation Steps Performed

Tests added & passed.

[skyline75489]

Pro tips: you may want to use "Split" mode to view the diff.

[zadjii-msft]

protip: also use the "Hide whitespace changes" option, makes this even easier to review.

[DHowett]

[skyline75489]

After some consideration, I've repurposed this PR to improve the OSC 8 hyperlink parsing, instead of just trying to make use of SplitString. I've added the support for : inside the OSC 8 params and added some test cases.

The usage of : is described here https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda#the-escape-sequence

[PankajBhojwani]

Looks good to me, thank you for this!

[skyline75489]

OK the result may seem weird in a general purpose function. But it works pretty well as for parameter parsing for VT sequences.

[skyline75489]

A ping to stop the bot from marking the PR as stale.

[DHowett]

Minor things

[skyline75489]

Well, what do you know, the "minor" thing is causing error C26445: A reference to gsl::span or std::string_view may be an indication of a lifetime issue (gsl.view)....

[DHowett]

Hmm. That warning seems to be overzealous. We should suppress it.

[github-actions]

New misspellings found, please review:

• quux

To accept these changes, run the following commands

perl -e '
my @expect_files=qw('".github/actions/spell-check/expect/alphabet.txt
.github/actions/spell-check/expect/expect.txt
.github/actions/spell-check/expect/web.txt"');
@ARGV=@expect_files;
my @stale=qw('"akb appdata Autogenerated autologin CParams cppcorecheck debian debugbreak decf DECLL DECSMBV esa FILEPATH guidgenerator hhhh Inplace keith keybound naws notypeopt openlogo restrictederrorinfo rgus richturn Scs SGRXY subnegotiation Switchto telnetpp winver Wlk wslhome xe "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^($re)(?:$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spell-check/expect/e79b117934a38399c30aedab4feb84fe15aa3bf5.txt";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"autogenerated CPPCORECHECK Debian filepath inplace quux WINVER "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
git add .github/actions/spell-check/expect || echo '... you want to ensure .github/actions/spell-check/expect/e79b117934a38399c30aedab4feb84fe15aa3bf5.txt is added to your repository...'

✏️ Contributor please read this

By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.

⚠️ The command is written for posix shells. You can copy the contents of each perl command excluding the outer ' marks and dropping any '"/"' quotation mark pairs into a file and then run perl file.pl from the root of the repository to run the code. Alternatively, you can manually insert the items...

If the listed items are:

• ... misspelled, then please correct them instead of using the command.
• ... names, please add them to .github/actions/spell-check/dictionary/names.txt.
• ... APIs, you can add them to a file in .github/actions/spell-check/dictionary/.
• ... just things you're using, please add them to an appropriate file in .github/actions/spell-check/expect/.
• ... tokens you only need in one place and shouldn't generally be used, you can add an item in an appropriate file in .github/actions/spell-check/patterns/.

See the README.md in each directory for more information.

🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The :check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉

⚠️ Reviewers

At present, the action that triggered this message will not show its ❌ in this PR unless the branch is within this repository.
Thus, you should make sure that this comment has been addressed before encouraging the merge bot to merge this PR.

[skyline75489]

Hey, what do you know, the tests passed like it should. @DHowett Can I get a green light on this one?

[DHowett]

Thanks! Sorry -- I was worried about making some string parsing changes as it were. I kicked back for far too long on this PR.

[ghost]

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.