UIA: throw E_FAIL for out-of-bounds text #8052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniksa
reviewed
Oct 27, 2020
miniksa
approved these changes
Oct 27, 2020
DHowett
reviewed
Oct 27, 2020
DHowett
requested changes
Oct 27, 2020
Member
DHowett
left a comment
DHowett
left a comment
There was a problem hiding this comment.
(noted in body)
Thanks for fixing this! and finding it!
ghost
added
the
Needs-Author-Feedback
Co-authored-by: Dustin L. Howett <dustin@howett.net>
ghost
removed
the
Needs-Author-Feedback
DHowett
approved these changes
Oct 27, 2020
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Member
|
Yeah, I'll bring this one up w/ my director |
ghost
merged commit
DHowett
pushed a commit
that referenced
this pull request
Oct 28, 2020
In nvaccess/nvda#11428 (comment), Andre9642 reported a Conhost crash when switching to/from the alt buffer a few times with a Braille display connected. Upon further investigation, @carlos-zamora and I discovered that the FailFast was in `GetText`: more checks similar to #7677 were needed for this case. Tested with NVDA using a [Focus](https://www.freedomscientific.com/products/blindness/focus40brailledisplay/) Braille display. Improves nvaccess/nvda#11428 (cherry picked from commit 60437b8)
|
🎉 Handy links: |
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In nvaccess/nvda#11428 (comment),
Andre9642 reported a Conhost crash when switching to/from the alt buffer
a few times with a Braille display connected. Upon further
investigation, @carlos-zamora and I discovered that the FailFast was in
GetText: more checks similar to #7677 were needed for this case.Tested with NVDA using a Focus Braille display.
Improves nvaccess/nvda#11428