Fix desktopWallpaper background image casing #8206
Conversation
| static constexpr std::string_view BellStyleKey{ "bellStyle" }; | ||
|
|
||
| static const winrt::hstring DesktopWallpaperEnum{ L"DesktopWallpaper" }; | ||
| static const winrt::hstring DesktopWallpaperEnum{ L"desktopWallpaper" }; |
There was a problem hiding this comment.
AGH
@carlos-zamora can you help make this not a statically-constructed hstring
ghost
added
the
Needs-Author-Feedback
ghost
removed
the
Needs-Author-Feedback
| static constexpr std::string_view BellStyleKey{ "bellStyle" }; | ||
|
|
||
| static const winrt::hstring DesktopWallpaperEnum{ L"DesktopWallpaper" }; | ||
| static const winrt::hstring DesktopWallpaperEnum{ L"desktopWallpaper" }; |
There was a problem hiding this comment.
| static const winrt::hstring DesktopWallpaperEnum{ L"desktopWallpaper" }; | |
| static const std::string_view DesktopWallpaperEnum{ L"desktopWallpaper" }; |
I think that's all you might have to do since to_hstring is called on this when it's needed below.
There was a problem hiding this comment.
uh this will definitely not work lol
why is it even a wide string
why did we put L on it
There was a problem hiding this comment.
Oh yeah, remove the L after making it a string_view
There was a problem hiding this comment.
Alright I think I fixed it
There was a problem hiding this comment.
Ok. I'm a dummy. Make it a std::wstring_view (and add the 'L' back in).
Since we're specifically comparing this to an hstring and hstrings are wide, keep this as a wstring and remove to to_hstring call when it's used.
Mind fixing it? It'll be a quick fix.
There was a problem hiding this comment.
Okay how about now?
ghost
added
Needs-Author-Feedback
| { | ||
| "enum": [ | ||
| "desktopWallpaper" | ||
| ] | ||
| } |
There was a problem hiding this comment.
Just double checking, you don't need "type": "string" here? It looks like "backgroundImageAlignment" below has it. Either way, thank you!
|
@msftbot merge this in 3 minutes |
ghost
added
the
AutoMerge
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit 
DesktopWallpapertodesktopWallpaperforbackgroundImageto match our other settings
desktopWallpaperto json schema