Skip to content

Conversation

@j4james
Copy link
Collaborator

@j4james j4james commented Dec 3, 2020

This corrects the path to Terminal.Core.Unit.Tests.dll in the runut
unit test script and makes the runft feature test script capable of
working with Release builds as well as Debug builds.

The path to Terminal.Core.Unit.Tests.dll changed when the project was
restructured, and the runut script was never updated to reflect that
change. That has now been corrected.

And the runft script used to be hard coded to look for tests in the
Debug directory, but it has now been updated to use the
%_LAST_BUILD_CONF% environment variable, so it should work for both
Debug and Release builds.

Validation Steps Performed

I've manually confirmed that the runut and runft scripts now work as
expected.

Closes #8485

@ghost ghost added Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Meta The product is the management of the products. labels Dec 3, 2020
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@zadjii-msft zadjii-msft added AutoMerge Marked for automatic merge by the bot when requirements are met Needs-Second It's a PR that needs another sign-off labels Dec 3, 2020
@ghost
Copy link

ghost commented Dec 3, 2020

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 22 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@DHowett
Copy link
Member

DHowett commented Dec 3, 2020

@msftbot merge this in 2 minutes

@ghost
Copy link

ghost commented Dec 3, 2020

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Thu, 03 Dec 2020 18:39:48 GMT, which is in 2 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@DHowett DHowett merged commit 3995196 into microsoft:main Dec 3, 2020
@microsoft microsoft deleted a comment Dec 3, 2020
@DHowett

This comment has been minimized.

@j4james j4james deleted the fix-test-scripts branch December 3, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Build Issues pertaining to the build system, CI, infrastructure, meta AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off Product-Meta The product is the management of the products.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some test scripts don't work correctly

4 participants