Skip to content

Add scrollToTop and scrollToBottom actions to JSON schema #8923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DHowett merged 1 commit into from
Jan 28, 2021
Merged

Add scrollToTop and scrollToBottom actions to JSON schema #8923

DHowett merged 1 commit into from
Jan 28, 2021

Conversation

@cinnamon-msft
Copy link
Contributor

@cinnamon-msft cinnamon-msft commented Jan 28, 2021 •
edited
Loading

Summary of the Pull Request

Simple JSON schema fix for 1.6 :)

scrollToTop and scrollToBottom are from #8459

References

PR Checklist

  • Closes Schema is missing scrollToTop and scrollToBottom actions #8892
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@ghost ghost added Area-Schema Things that have to do with the json schema. Area-Settings Issues related to settings and customizability, for console or terminal Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Product-Terminal The new Windows Terminal. labels Jan 28, 2021
@DHowett DHowett merged commit b502e0e into main Jan 28, 2021
@DHowett DHowett deleted the cinnamon/scrollhome-schema branch January 28, 2021 17:38
mpela81 pushed a commit to mpela81/terminal that referenced this pull request Jan 28, 2021
@cinnamon-msft @mpela81
Add scrollToTop and scrollToBottom actions to JSON schema (micros…
58ea3fd 
…oft#8923)

Closes microsoft#8992.
DHowett pushed a commit that referenced this pull request Feb 5, 2021
@cinnamon-msft @DHowett
Add scrollToTop and scrollToBottom actions to JSON schema (#8923)
5b1137c 
Closes #8992.

(cherry picked from commit b502e0e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees

No one assigned

Labels

Area-Schema Things that have to do with the json schema. Area-Settings Issues related to settings and customizability, for console or terminal Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Product-Terminal The new Windows Terminal.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Schema is missing scrollToTop and scrollToBottom actions

4 participants

@cinnamon-msft @DHowett @zadjii-msft