Skip to content

Update README.md - Build the Code section #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
3 commits merged into from
May 21, 2019
Merged

Update README.md - Build the Code section #899

3 commits merged into from
May 21, 2019

Conversation

@coderitual
Copy link
Contributor

@coderitual coderitual commented May 19, 2019 •
edited
Loading

Fix readme to show correct path of build tools

Summary of the Pull Request

Fix README.md documentation in Build the Code section

References

PR Checklist

  • Closes Documentation Issue - "Build the Code" section #898
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

It might be fixed also by adding path to bcz in razzle command.

@coderitual
Update README.md
20f264e 
Fix readme to show correct path of build tools
oising
oising suggested changes May 19, 2019
View reviewed changes
@ghost ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels May 19, 2019
@zadjii-msft zadjii-msft added the Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs label May 20, 2019
@coderitual
Update README.md
6ce7a02 
Add mention about recommended cli tool for building.
DHowett-MSFT
DHowett-MSFT reviewed May 20, 2019
View reviewed changes
@coderitual
Update README.md
b863187 
Cover powershell in build section
DHowett-MSFT
DHowett-MSFT approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DHowett-MSFT DHowett-MSFT added the AutoMerge Marked for automatic merge by the bot when requirements are met label May 20, 2019
@ghost
Copy link

ghost commented May 20, 2019

Hello @DHowett-MSFT!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me and give me an instruction to get started! Learn more here.

@DHowett-MSFT
Copy link
Contributor

DHowett-MSFT commented May 20, 2019

@msftbot make sure @oising signs off

@ghost
Copy link

ghost commented May 20, 2019

Hello @DHowett-MSFT!

I think you told me that you want @oising to approve this pull request before I perform the merge, but I am not confident that I have understood you correctly.

Please try rephrasing your instruction to me.

@DHowett-MSFT
Copy link
Contributor

DHowett-MSFT commented May 20, 2019

really?

@miniksa
Copy link
Member

miniksa commented May 20, 2019

@msftbot make sure @oising signs off

@ghost
Copy link

ghost commented May 20, 2019

Hello @miniksa!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I'll only merge this pull request if it's approved by @oising

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@miniksa
Copy link
Member

miniksa commented May 20, 2019

@DHowett-MSFT, it just likes me better.

@ghost ghost merged commit 080843f into microsoft:master May 21, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miniksa miniksa miniksa approved these changes

+3 more reviewers

@oising oising oising approved these changes

@adiviness adiviness adiviness approved these changes

@DHowett-MSFT DHowett-MSFT DHowett-MSFT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation Issue - "Build the Code" section

6 participants

@coderitual @DHowett-MSFT @miniksa @oising @adiviness @zadjii-msft