Bugfix: padding offsets selection #906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett-MSFT
approved these changes
May 20, 2019
Contributor
DHowett-MSFT
left a comment
DHowett-MSFT
left a comment
There was a problem hiding this comment.
migrating approval from vso
zadjii-msft
approved these changes
May 20, 2019
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Padding used to offset selection.
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
Created
_GetTerminalPosition()to encompass some of this logic and prevent this kind of stuff from happening again. Also, just nice to wrap everything up into a function call.To the team: this was already somewhat reviewed back before we went on GitHub. So if you have a deja vu feeling, that's why.