Skip to content

Represent Cursor Height as a slider #9383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eugenesmlv wants to merge 3 commits into from
Closed

Represent Cursor Height as a slider #9383

eugenesmlv wants to merge 3 commits into from

Conversation

@eugenesmlv
Copy link
Contributor

@eugenesmlv eugenesmlv commented Mar 4, 2021

Summary of the Pull Request

Change the vintage cursor height number box to slider.

References

Related: #9370

PR Checklist

  • Closes Represent Cursor Height as a slider #9377
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

It seems like the cursor height couldn't be lower than 25 percent regardless of the given value, so I've changed the MinCursorHeightPercent in CustomTextRenderer header file.

Validation Steps Performed

Manual validation

CursorHeightSlider

@ghost ghost added Area-SettingsUI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Mar 4, 2021
@eugenesmlv
Copy link
Contributor Author

eugenesmlv commented Mar 5, 2021 •
edited
Loading

Sorry, I've made a mess trying to resolve a merge conflict so I'm closing this PR and opening a new one (#9386).

@eugenesmlv eugenesmlv closed this Mar 5, 2021
@eugenesmlv eugenesmlv deleted the cursor-height-slider branch March 5, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Area-SettingsUI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Represent Cursor Height as a slider

1 participant

@eugenesmlv