Support php 'never' type, change parsing of 'void' #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
There are no test cases that have to be changed as a result of the 'void' change? Should there be? |
Similar to 'void', it's a compile time error to use void as a parameter/property type, not a parse time error. But `static` is a parse error. (It can also be used in union types) Remove redundant tokens added to merged returnTypeDeclarationTokens Closes microsoft#373 Closes microsoft#372
TysonAndre
force-pushed
the
support-never
branch
from
ec71f0d to
0d46605
Compare
Contributor
Author
|
I added a test that void/never are now allowed in parameter types. There weren't any before. Aside: tests/cases/parser/staticReturnType2.php already tests that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to 'void', it's a compile time error to use void as a
parameter/property type, not a parse time error.
But
staticis a parse error.(It can also be used in union types)
Remove redundant tokens added to merged returnTypeDeclarationTokens
Closes #373
Closes #372