Skip to content

docs: bootloader-configuration#256

Merged
bfjelds merged 19 commits into
mainfrom
user/bfjelds/bootloader-configuration
Oct 14, 2025
Merged

docs: bootloader-configuration#256
bfjelds merged 19 commits into
mainfrom
user/bfjelds/bootloader-configuration

Conversation

@bfjelds
Copy link
Copy Markdown
Member

@bfjelds bfjelds commented Oct 9, 2025

No description provided.

@bfjelds bfjelds requested a review from a team as a code owner October 9, 2025 18:47
Copilot AI review requested due to automatic review settings October 9, 2025 18:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive documentation for bootloader configuration in Trident, replacing a placeholder document with detailed explanation of how Trident handles GRUB and systemd-boot bootloaders.

  • Explains COSI configuration requirements for different bootloader types
  • Documents bootloader servicing process including A/B update handling
  • Details systemd-boot specific naming conventions and file management

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread docs/Explanation/Bootloader-Configuration.md Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings October 9, 2025 18:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread docs/Explanation/Bootloader-Configuration.md Outdated
Copilot AI review requested due to automatic review settings October 9, 2025 18:59
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread docs/Explanation/Bootloader-Configuration.md Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings October 9, 2025 19:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ayaegashi
Copy link
Copy Markdown
Contributor

iirc bootloader configuration is closely related to encryption. Wondering if there would be a useful snippet to include about encryption in this doc, @ndubchak

Copilot AI review requested due to automatic review settings October 9, 2025 20:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@bfjelds
Copy link
Copy Markdown
Member Author

bfjelds commented Oct 9, 2025

iirc bootloader configuration is closely related to encryption. Wondering if there would be a useful snippet to include about encryption in this doc, @ndubchak

added a note that references encryption api-reference pcr section.

Comment thread docs/Explanation/Bootloader-Configuration.md Outdated
Comment thread docs/Explanation/Bootloader-Configuration.md Outdated
Comment thread docs/Explanation/Bootloader-Configuration.md Outdated
Britel
Britel previously approved these changes Oct 10, 2025
Copy link
Copy Markdown
Collaborator

@Britel Britel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small suggestions. Otherwise good to go

Co-authored-by: Brian Telfer <britel@microsoft.com>
Copilot AI review requested due to automatic review settings October 10, 2025 14:47
Co-authored-by: Brian Telfer <britel@microsoft.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread docs/Explanation/Bootloader-Configuration.md
Comment thread docs/Explanation/Bootloader-Configuration.md Outdated
Comment thread docs/Explanation/Bootloader-Configuration.md
Comment thread docs/Explanation/Bootloader-Configuration.md Outdated
Comment thread docs/Explanation/Bootloader-Configuration.md Outdated
Copilot AI review requested due to automatic review settings October 10, 2025 21:50
Comment thread docs/Explanation/Bootloader-Configuration.md
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread docs/Explanation/Bootloader-Configuration.md
Comment thread docs/Explanation/Bootloader-Configuration.md Outdated
Comment thread docs/Explanation/Bootloader-Configuration.md
bfjelds and others added 2 commits October 10, 2025 21:52
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings October 10, 2025 21:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings October 10, 2025 22:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread docs/Explanation/Bootloader-Configuration.md
Comment thread docs/Explanation/Bootloader-Configuration.md Outdated
Copilot AI review requested due to automatic review settings October 14, 2025 00:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings October 14, 2025 20:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

illustrate how this process works.
:::

In order to support A/B update from a single ESP partition, Trident needs to
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical number issue: change 'A/B update' to 'A/B updates' (general capability) for clarity.

Suggested change
In order to support A/B update from a single ESP partition, Trident needs to
In order to support A/B updates from a single ESP partition, Trident needs to

Copilot uses AI. Check for mistakes.
* `/boot/efi/EFI/AZLA` - the target OS for the initial install
* `/boot/efi/EFI/AZLB` - the target OS for a future update

Within the bootloader paths, Trident will copy efi files (like `boot<ARCH>.efi`
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acronym 'EFI' should be capitalized for consistency with earlier usage (e.g., 'EFI/AZLA').

Suggested change
Within the bootloader paths, Trident will copy efi files (like `boot<ARCH>.efi`
Within the bootloader paths, Trident will copy EFI files (like `boot<ARCH>.efi`

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

it is versioned with the kernel version (for example
`/boot/efi/EFI/Linux/vmlinuz-6.6.96.2-2.azl3.efi`), to
[`/boot/efi/EFI/Linux`](https://uapi-group.org/specifications/specs/boot_loader_specification/#locating-boot-entries)
on the target OS. Trident will rename the UKI efi file to ensure that the
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize the acronym 'EFI' for consistency ('UKI EFI file').

Suggested change
on the target OS. Trident will rename the UKI efi file to ensure that the
on the target OS. Trident will rename the UKI EFI file to ensure that the

Copilot uses AI. Check for mistakes.

For example, the first install of a single OS would create
`/boot/efi/EFI/Linux/vmlinuz-100-azla0.efi`. A subsequent update would create
`/boot/efi/EFI/Linux/vmlinuz-101-azlb0.efi`. A subsequent update would create
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The phrase 'A subsequent update would create' is repeated on consecutive lines, which can be confusing. Consider rephrasing the second occurrence to 'The next update would create' or enumerate the sequence.

Suggested change
`/boot/efi/EFI/Linux/vmlinuz-101-azlb0.efi`. A subsequent update would create
`/boot/efi/EFI/Linux/vmlinuz-101-azlb0.efi`. The next update would create

Copilot uses AI. Check for mistakes.
@bfjelds bfjelds merged commit 065568d into main Oct 14, 2025
11 checks passed
@bfjelds bfjelds deleted the user/bfjelds/bootloader-configuration branch February 13, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants