docs: bootloader-configuration#256
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive documentation for bootloader configuration in Trident, replacing a placeholder document with detailed explanation of how Trident handles GRUB and systemd-boot bootloaders.
- Explains COSI configuration requirements for different bootloader types
- Documents bootloader servicing process including A/B update handling
- Details systemd-boot specific naming conventions and file management
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
iirc bootloader configuration is closely related to encryption. Wondering if there would be a useful snippet to include about encryption in this doc, @ndubchak |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
added a note that references encryption api-reference pcr section. |
Britel
left a comment
There was a problem hiding this comment.
Left some small suggestions. Otherwise good to go
Co-authored-by: Brian Telfer <britel@microsoft.com>
Co-authored-by: Brian Telfer <britel@microsoft.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| illustrate how this process works. | ||
| ::: | ||
|
|
||
| In order to support A/B update from a single ESP partition, Trident needs to |
There was a problem hiding this comment.
Grammatical number issue: change 'A/B update' to 'A/B updates' (general capability) for clarity.
| In order to support A/B update from a single ESP partition, Trident needs to | |
| In order to support A/B updates from a single ESP partition, Trident needs to |
| * `/boot/efi/EFI/AZLA` - the target OS for the initial install | ||
| * `/boot/efi/EFI/AZLB` - the target OS for a future update | ||
|
|
||
| Within the bootloader paths, Trident will copy efi files (like `boot<ARCH>.efi` |
There was a problem hiding this comment.
Acronym 'EFI' should be capitalized for consistency with earlier usage (e.g., 'EFI/AZLA').
| Within the bootloader paths, Trident will copy efi files (like `boot<ARCH>.efi` | |
| Within the bootloader paths, Trident will copy EFI files (like `boot<ARCH>.efi` |
| it is versioned with the kernel version (for example | ||
| `/boot/efi/EFI/Linux/vmlinuz-6.6.96.2-2.azl3.efi`), to | ||
| [`/boot/efi/EFI/Linux`](https://uapi-group.org/specifications/specs/boot_loader_specification/#locating-boot-entries) | ||
| on the target OS. Trident will rename the UKI efi file to ensure that the |
There was a problem hiding this comment.
Capitalize the acronym 'EFI' for consistency ('UKI EFI file').
| on the target OS. Trident will rename the UKI efi file to ensure that the | |
| on the target OS. Trident will rename the UKI EFI file to ensure that the |
|
|
||
| For example, the first install of a single OS would create | ||
| `/boot/efi/EFI/Linux/vmlinuz-100-azla0.efi`. A subsequent update would create | ||
| `/boot/efi/EFI/Linux/vmlinuz-101-azlb0.efi`. A subsequent update would create |
There was a problem hiding this comment.
[nitpick] The phrase 'A subsequent update would create' is repeated on consecutive lines, which can be confusing. Consider rephrasing the second occurrence to 'The next update would create' or enumerate the sequence.
| `/boot/efi/EFI/Linux/vmlinuz-101-azlb0.efi`. A subsequent update would create | |
| `/boot/efi/EFI/Linux/vmlinuz-101-azlb0.efi`. The next update would create |
No description provided.