Skip to content

Improve UKI detection#46

Merged
fintelia merged 5 commits into
mainfrom
jbehrens/uki-detection
Jul 25, 2025
Merged

Improve UKI detection#46
fintelia merged 5 commits into
mainfrom
jbehrens/uki-detection

Conversation

@fintelia
Copy link
Copy Markdown
Contributor

This PR changes code to only check for the UKI internal param once and modifies rollback logic to use the LoaderEntrySelected UEFI variable to determine whether the the system booted via UKI.

@fintelia fintelia requested a review from a team as a code owner July 22, 2025 00:03
Comment thread src/engine/context/mod.rs
ayaegashi
ayaegashi previously approved these changes Jul 22, 2025
Comment thread src/engine/rollback.rs Outdated
ndubchak
ndubchak previously approved these changes Jul 22, 2025
bfjelds
bfjelds previously approved these changes Jul 23, 2025
@fintelia fintelia dismissed stale reviews from bfjelds and ndubchak via 327d0d0 July 24, 2025 20:32
@fintelia fintelia force-pushed the jbehrens/uki-detection branch from 3610717 to 327d0d0 Compare July 24, 2025 20:32
@fintelia fintelia merged commit 144e41d into main Jul 25, 2025
62 checks passed
@fintelia fintelia deleted the jbehrens/uki-detection branch July 25, 2025 18:48
alejandro-microsoft pushed a commit that referenced this pull request Aug 4, 2025
bfjelds added a commit that referenced this pull request May 25, 2026
Fixes from frhuelsz code review:

- grub_cfg: skip $variable references during partition extraction (#30)
- users: use * lock marker instead of ! for AZL UsePAM=no (#31)
- users: fsync + parent dir sync in atomic_write_file (#33)
- users: propagate unexpected errors from check_user_exists (#36)
- users: explicitly lock new users when no password set (#43)
- users: skip set_primary_group for new users (useradd -g suffices) (#46)
- users: named constants for shadow/passwd field indices (#41)
- users: named constants for SSH dir/file permissions (#52)
- config: add deny_unknown_fields to remaining serde structs (#38)
- config: doc comment on PasswordType intentional reduction (#37)
- services: error on non-UTF-8 root path instead of silent fallback (#51)
- modules: document intentional Disable fidelity fix vs Go (#50)
- selinux: doc comment clarifying non-overlapping call paths (#45)
- lib: update OsModifierContext doc for MOS config path (#54)
- lib: add caller invariant doc on modify_os for UKI (#32)
- lib: add BootTarget enum note for future UKI-awareness (#53)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants