bug: pcrlock predict uses sort order to predict, so addons need to load between uki (650-*) and uki .linux (660-*)#568
Merged
Conversation
…tween uki (650-*) and uki .linux (660-*)
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the pcrlock.d component naming used for UKI add-ons so systemd-pcrlock predict’s lexicographic sort order matches the real TPM measurement order on bare metal.
Changes:
- Renames the UKI add-ons
.pcrlock.ddirectory prefix from670-uki-addons-to655-uki-addons-to ensure it sorts between650-*(UKI) and660-*(UKI.linuxsection).
fintelia
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 Description
systemd-pcrlock predictdepends on the pcrlock.d folder sort order to match the measurement order.Using
670-uki-addons-*as a pcrlock.d folder name misordered the component. This only repro's on baremetal because we have SecureBoot enabled in VM tests (in which case, the uki .linux section is not measured).systemd-pcrlock logdumps the events in order, where the uki add-on (670-*) is loaded after the uki (650-*) and before the uki .linux section (660-*):systemd-pcrlock list-componentsshows the sort order that predict uses, where the uki addon is used after both the uki and uki .linux section:The fix is to change the pcrlock folder name to sit between uki (650) and uki .linux (660).
Verified on baremetal manually, vm tests still succeed: https://dev.azure.com/mariner-org/ECF/_build/results?buildId=1074120&view=results