Skip to content

feature: Promote gRPC UpdateService to v1#581

Merged
frhuelsz merged 2 commits into
mainfrom
user/frhuelsz/grpc/update-stable
Apr 1, 2026
Merged

feature: Promote gRPC UpdateService to v1#581
frhuelsz merged 2 commits into
mainfrom
user/frhuelsz/grpc/update-stable

Conversation

@frhuelsz
Copy link
Copy Markdown
Contributor

🔍 Description

Promote UpdateService to v1 stable.

@frhuelsz frhuelsz requested a review from a team as a code owner March 27, 2026 23:57
Copilot AI review requested due to automatic review settings March 27, 2026 23:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Promotes the gRPC UpdateService from the preview API surface into the stable trident.v1 API, and updates related proto/Rust wiring so the server and client use the v1-generated types.

Changes:

  • Move UpdateService proto package from trident.v1preview to trident.v1 and adjust referenced message types accordingly.
  • Promote HostConfiguration into trident.v1 and update v1preview protos to reference trident.v1.HostConfiguration.
  • Register the v1 UpdateService on the server unconditionally and update Rust service/client imports to use trident_proto::v1.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
proto/trident/v1preview/validation_service.proto Switches HostConfiguration dependency to trident.v1 and qualifies message types.
proto/trident/v1preview/status_service.proto Switches HostConfiguration dependency to trident.v1 and qualifies message types.
proto/trident/v1preview/install_service.proto Switches HostConfiguration dependency to trident.v1 and qualifies message types.
proto/trident/v1/update_service.proto Promotes UpdateService into trident.v1 package and uses in-package type references.
proto/trident/v1/host_config.proto Promotes HostConfiguration into trident.v1 package.
crates/trident/src/server/tridentserver/services/update.rs Updates the service implementation to the v1-generated proto module.
crates/trident/src/server/tridentserver/services/mod.rs Makes the update service module part of the non-preview service set.
crates/trident/src/server/mod.rs Registers UpdateServiceServer in the non-preview server router.
crates/trident/src/grpc_client/tridentclient.rs Switches to v1 UpdateServiceClient and moves HostConfiguration import to v1 for preview install calls.

@frhuelsz frhuelsz merged commit 34f1a00 into main Apr 1, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants