feature: Promote gRPC UpdateService to v1#581
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Promotes the gRPC UpdateService from the preview API surface into the stable trident.v1 API, and updates related proto/Rust wiring so the server and client use the v1-generated types.
Changes:
- Move
UpdateServiceproto package fromtrident.v1previewtotrident.v1and adjust referenced message types accordingly. - Promote
HostConfigurationintotrident.v1and update v1preview protos to referencetrident.v1.HostConfiguration. - Register the v1
UpdateServiceon the server unconditionally and update Rust service/client imports to usetrident_proto::v1.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| proto/trident/v1preview/validation_service.proto | Switches HostConfiguration dependency to trident.v1 and qualifies message types. |
| proto/trident/v1preview/status_service.proto | Switches HostConfiguration dependency to trident.v1 and qualifies message types. |
| proto/trident/v1preview/install_service.proto | Switches HostConfiguration dependency to trident.v1 and qualifies message types. |
| proto/trident/v1/update_service.proto | Promotes UpdateService into trident.v1 package and uses in-package type references. |
| proto/trident/v1/host_config.proto | Promotes HostConfiguration into trident.v1 package. |
| crates/trident/src/server/tridentserver/services/update.rs | Updates the service implementation to the v1-generated proto module. |
| crates/trident/src/server/tridentserver/services/mod.rs | Makes the update service module part of the non-preview service set. |
| crates/trident/src/server/mod.rs | Registers UpdateServiceServer in the non-preview server router. |
| crates/trident/src/grpc_client/tridentclient.rs | Switches to v1 UpdateServiceClient and moves HostConfiguration import to v1 for preview install calls. |
bfjelds
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 Description
Promote UpdateService to v1 stable.