feature: Promote gRPC Commit to v1 stable#582
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR promotes the gRPC Commit operation from the v1preview API surface to the stable trident.v1 API, updating server wiring and client/proto definitions accordingly.
Changes:
- Move
CommitService/CommitRPC andCommitRequestmessage fromproto/trident/v1previewinto a new stableproto/trident/v1/commit_service.proto. - Register the stable
CommitServiceServerin the gRPC server and implement the stableCommitServicetrait onTridentServer. - Adjust server module gating so required shared helpers (e.g., datastore helpers) compile in non-preview builds, and update the Rust gRPC client imports for v1 Commit.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| proto/trident/v1preview/commit_service.proto | Removes preview Commit RPC and CommitRequest message, leaving only CheckRoot. |
| proto/trident/v1/commit_service.proto | Adds new stable v1 CommitService with Commit RPC and CommitRequest. |
| crates/trident/src/server/tridentserver/services/mod.rs | Makes commit service module always compiled (not preview-gated). |
| crates/trident/src/server/tridentserver/services/commit.rs | Implements stable v1 CommitService::commit; keeps preview CheckRoot implementation behind feature flag. |
| crates/trident/src/server/tridentserver/mod.rs | Makes datastore module always available (not preview-gated). |
| crates/trident/src/server/tridentserver/datastore.rs | Keeps stored_image_hash available generally; moves preview-only state mapping into a preview-gated submodule and re-export. |
| crates/trident/src/server/mod.rs | Registers stable CommitServiceServer unconditionally; aliases preview server type under feature flag. |
| crates/trident/src/grpc_client/tridentclient.rs | Switches commit client/request types to v1 stable; retains preview-only clients for other preview services. |
frhuelsz
commented
Apr 2, 2026
bfjelds
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote gRPC Commit to v1 stable