Skip to content

feature: Promote gRPC Commit to v1 stable#582

Merged
frhuelsz merged 4 commits into
mainfrom
user/frhuelsz/grpc/commit-stable
Apr 3, 2026
Merged

feature: Promote gRPC Commit to v1 stable#582
frhuelsz merged 4 commits into
mainfrom
user/frhuelsz/grpc/commit-stable

Conversation

@frhuelsz
Copy link
Copy Markdown
Contributor

Promote gRPC Commit to v1 stable

@frhuelsz frhuelsz requested a review from a team as a code owner March 28, 2026 00:43
Copilot AI review requested due to automatic review settings March 28, 2026 00:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR promotes the gRPC Commit operation from the v1preview API surface to the stable trident.v1 API, updating server wiring and client/proto definitions accordingly.

Changes:

  • Move CommitService/Commit RPC and CommitRequest message from proto/trident/v1preview into a new stable proto/trident/v1/commit_service.proto.
  • Register the stable CommitServiceServer in the gRPC server and implement the stable CommitService trait on TridentServer.
  • Adjust server module gating so required shared helpers (e.g., datastore helpers) compile in non-preview builds, and update the Rust gRPC client imports for v1 Commit.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
proto/trident/v1preview/commit_service.proto Removes preview Commit RPC and CommitRequest message, leaving only CheckRoot.
proto/trident/v1/commit_service.proto Adds new stable v1 CommitService with Commit RPC and CommitRequest.
crates/trident/src/server/tridentserver/services/mod.rs Makes commit service module always compiled (not preview-gated).
crates/trident/src/server/tridentserver/services/commit.rs Implements stable v1 CommitService::commit; keeps preview CheckRoot implementation behind feature flag.
crates/trident/src/server/tridentserver/mod.rs Makes datastore module always available (not preview-gated).
crates/trident/src/server/tridentserver/datastore.rs Keeps stored_image_hash available generally; moves preview-only state mapping into a preview-gated submodule and re-export.
crates/trident/src/server/mod.rs Registers stable CommitServiceServer unconditionally; aliases preview server type under feature flag.
crates/trident/src/grpc_client/tridentclient.rs Switches commit client/request types to v1 stable; retains preview-only clients for other preview services.

Comment thread crates/trident/src/grpc_client/tridentclient.rs
Comment thread proto/trident/v1preview/commit_service.proto
Comment thread proto/trident/v1/commit_service.proto Outdated
@frhuelsz frhuelsz merged commit 0b3276c into main Apr 3, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants