engineering: Add launcher binary#593
Merged
Merged
Conversation
cb15b15 to
4dc818a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reintroduces an Omaha (Nebraska) client flow by adding a new launcher binary/crate and wiring it into existing provisioning/update pathways so test images can download and (eventually) use it alongside Trident.
Changes:
- Added a new Rust workspace member
crates/launcherimplementing basic Omaha request/response handling and a CLI entrypoint. - Integrated
launcherinto netlaunch RCP file injection and the test image systemd unit that downloads binaries. - Updated build tooling to produce
bin/launcher(via AZL3 Docker build) and copylauncherduring Trident self-upgrade provisioning.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/pkg/netlaunch/netlaunch.go | Injects bin/launcher into the RCP-served files for test/provisioning flows. |
| tests/images/trident-mos/files/download-trident.service | Downloads /usr/bin/launcher alongside existing downloaded binaries. |
| Makefile | Builds launcher in build-azl3, installs to bin/launcher, and adds it to run-netlaunch prerequisites. |
| crates/trident/src/subsystems/management.rs | Copies /usr/bin/launcher into the target OS when SELF_UPGRADE_TRIDENT is enabled. |
| crates/launcher/src/omaha/xml.rs | Adds helper macro for deserializing nested “list” XML elements. |
| crates/launcher/src/omaha/status.rs | Defines Omaha status enums and helpers (+ unit tests). |
| crates/launcher/src/omaha/response.rs | Implements Omaha response parsing/validation (+ unit tests). |
| crates/launcher/src/omaha/request.rs | Implements Omaha request modeling and XML serialization (+ unit tests). |
| crates/launcher/src/omaha/mod.rs | Implements blocking Omaha request execution and event validation (+ unit tests). |
| crates/launcher/src/omaha/event.rs | Defines Omaha event payloads and acknowledgement parsing. |
| crates/launcher/src/omaha/app.rs | Adds AppVersion wrapper around semver::Version (+ unit tests). |
| crates/launcher/src/main.rs | Adds launcher CLI + Trident gRPC update trigger + query logic (+ unit tests). |
| crates/launcher/src/id.rs | Adds machine ID/hostname sourcing for Omaha identifiers. |
| crates/launcher/src/error.rs | Adds HarpoonError error model for launcher/Omaha operations. |
| crates/launcher/Cargo.toml | Defines the new launcher crate dependencies. |
| Cargo.toml | Adds crates/launcher to the workspace members. |
| Cargo.lock | Updates lockfile for the new crate/dependency graph. |
frhuelsz
reviewed
Apr 9, 2026
frhuelsz
reviewed
Apr 9, 2026
frhuelsz
reviewed
Apr 10, 2026
frhuelsz
previously approved these changes
Apr 10, 2026
frhuelsz
reviewed
Apr 10, 2026
Contributor
Author
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3cbb404 to
9d9b68f
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
9d9b68f to
4de9c15
Compare
Contributor
Author
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
frhuelsz
approved these changes
Apr 14, 2026
bfjelds
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 Description
This PR restores much of the old harpoon code to connect to Omaha servers, and implements a simple launcher binary that queries an Omaha server then connects to trident and does an update with the indicated COSI file