feature: Add sub-package for trident-acl-agent#640
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds packaging and build support for a new trident-acl-agent sub-package so it can be built, included in RPM artifacts, and extracted alongside the main trident binary.
Changes:
- Introduces an RPM subpackage (
acl-agent) and installs the new binary into the RPM buildroot. - Updates the AZL3 Docker RPM build to include the
trident-acl-agentbinary. - Extends the extraction script and Makefile pipeline to locate/build/package the new RPM/binary.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| scripts/extract-binary.sh | Adds logic to locate and extract trident-acl-agent from its subpackage RPM |
| packaging/rpm/trident.spec | Adds acl-agent subpackage and builds/installs the new binary |
| packaging/docker/Dockerfile.azl3 | Copies trident-acl-agent into the container build context for RPM creation |
| Makefile | Ensures trident-acl-agent is staged into bin/ and included as a dependency for RPM build tarball |
…iables Agent-Logs-Url: https://github.com/microsoft/trident/sessions/6d4cc1e1-b1f3-4ebe-938e-f5e4e2841c73 Co-authored-by: fintelia <4943209+fintelia@users.noreply.github.com>
bfjelds
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.