engineering: [osmodifier follow-up] add hostname and overlay input validation#654
Merged
Merged
Conversation
bfjelds
changed the title
bfjelds
changed the title
Port validation parity from Go osmodifierapi.OS.IsValid(): - Hostname validation matching govalidator.IsDNSName() plus underscore rejection: label length 1-63, total ≤255, alphanumeric+hyphen only, no leading/trailing hyphens, no underscores, no IP addresses, optional trailing dot. - Duplicate overlay path detection: reject duplicate upper_dir or work_dir values across overlays (separate sets, matching Go). Both validate() methods are called at the top of modify_os() and modify_boot() respectively, failing fast before any filesystem writes. Addresses review comment on PR #638 about input validation parity gap. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bfjelds
force-pushed
the
user/bfjelds/mjolnir/osmodifier-input-validation
branch
from
e328637 to
c22cbcb
Compare
bfjelds
changed the base branch from
user/bfjelds/mjolnir/port-osmodifier-to-rust
to
main
Member
Author
|
/azp run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds early, Go-parity input validation to the Rust crates/osmodifier entry points so invalid hostname/overlay inputs fail fast before any filesystem modifications occur.
Changes:
- Call
validate()at the start ofmodify_os()andmodify_boot()to fail fast on invalid configs. - Add hostname validation to
OSModifierConfig(DNS-name rules + underscore rejection + reject IP literals + allow trailing dot). - Add duplicate overlay path detection to
BootConfig(uniqueupper_dirandwork_dirwithin their respective sets), plus unit tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
crates/osmodifier/src/lib.rs |
Ensures OS/boot modifications validate configuration before performing any operations. |
crates/osmodifier/src/config.rs |
Implements hostname and overlay validation logic and adds unit tests for the new validation behavior. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Member
Author
|
/azp run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
fintelia
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 Description
Follow up to #638
Port validation parity from Go osmodifierapi.OS.IsValid():
Hostname validation matching govalidator.IsDNSName() plus underscore rejection: label length 1-63, total ≤255, alphanumeric+hyphen only, no leading/trailing hyphens, no underscores, no IP addresses, optional trailing dot.
Duplicate overlay path detection: reject duplicate upper_dir or work_dir values across overlays (separate sets, matching Go).
Both validate() methods are called at the top of modify_os() and modify_boot() respectively, failing fast before any filesystem writes.
Addresses review comment on PR #638 about input validation parity gap.