engineering: Implement is_secure_boot_enabled()#88
Merged
Conversation
frhuelsz
reviewed
Aug 5, 2025
| use crate::dependencies::{Dependency, DependencyResultExt}; | ||
|
|
||
| const BOOTLOADER_INTERFACE_GUID: &str = "4a67b082-0a4c-41cf-b6c7-440b29bb8c4f"; | ||
| const EFI_GLOBAL_VARIABLE_GUID: &str = "8be4df61-93ca-11d2-aa0d-00e098032b8c"; |
Contributor
There was a problem hiding this comment.
curious: are these GUIDs universal for all devices and architectures?
Contributor
There was a problem hiding this comment.
Yes, this GUID comes directly from the UEFI spec
bfjelds
approved these changes
Aug 6, 2025
ndubchak
force-pushed
the
ndubchak/add-secure-boot-check
branch
from
c9c4474 to
694963c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 Description
This PR adds a method
is_secure_boot_enabled()that is needed to use the EFI var-s, to check if the system hasSecureBootenabled. This is needed because the firmware and SHIM make different measurements into PCRs 4 and 7 (at least), depending on the state ofSecureBoot.