Skip to content

breaking: remove trident.selfUpgrade in favor of internalParams.selfUpgradeTrident#89

Merged
bfjelds merged 6 commits into
mainfrom
user/bfjelds/self-upgrade-as-internal-param
Aug 6, 2025
Merged

breaking: remove trident.selfUpgrade in favor of internalParams.selfUpgradeTrident#89
bfjelds merged 6 commits into
mainfrom
user/bfjelds/self-upgrade-as-internal-param

Conversation

@bfjelds
Copy link
Copy Markdown
Member

@bfjelds bfjelds commented Aug 5, 2025

🔍 Description

In HostConfiguration, move trident.selfUpgrade to internalParams.selfUpgradeTrident.

🤔 Rationale

selfUpgrade is an internal concept to help test/development, not a feature we want to support

📝 Checks

Comment thread functional_tests/trident-setup.yaml
Comment thread setsail/src/translator/mod.rs Outdated
Comment thread trident_api/src/config/host/mod.rs Outdated
Comment thread trident_api/src/constants.rs
@bfjelds bfjelds marked this pull request as ready for review August 5, 2025 21:15
@bfjelds bfjelds requested a review from a team as a code owner August 5, 2025 21:15
@bfjelds
Copy link
Copy Markdown
Member Author

bfjelds commented Aug 5, 2025

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@bfjelds bfjelds merged commit 21dfd23 into main Aug 6, 2025
9 checks passed
@bfjelds bfjelds deleted the user/bfjelds/self-upgrade-as-internal-param branch August 13, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants