Add container registry mirroring#315
Merged
johnstairs merged 21 commits intomainfrom Apr 28, 2026
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
There was a problem hiding this comment.
Pull request overview
Adds optional Azure Container Registry (ACR) mirroring to the Azure cloud installer via cloud.containerRegistryMirror, so installs can run in environments that must pull all images/charts from a private registry.
Changes:
- Adds mirroring workflow for Helm charts and container images, including Helm value rewriting and rendered-manifest validation.
- Extends RBAC preflight checks and AKS ACR attachment logic to include the mirror registry.
- Updates docs/config templates and adds unit tests for mirroring and ACR auth/token exchange.
Reviewed changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/introduction/installation/cloud-installation.md | Documents cloud.containerRegistryMirror usage and private-link guidance. |
| deploy/config/microsoft/cloudconfig.yml | Adds containerRegistryMirror to the base cloud config template. |
| deploy/config/microsoft/cloudconfig-private-link.yml | Adds containerRegistryMirror to the private-link sample config. |
| cli/internal/install/cloudinstall/cloud-config-pretty.tpl | Adds pretty-printed config support for containerRegistryMirror. |
| cli/internal/install/cloudinstall/cloudconfig.go | Adds containerRegistryMirror field and helper to include it in ACR attachment list. |
| cli/internal/install/cloudinstall/cloudconfig_test.go | Tests containerRegistriesForClusterAccess behavior with/without mirror. |
| cli/internal/install/cloudinstall/preflight.go | Adds required-action constants and mirror-specific RBAC checks. |
| cli/internal/install/cloudinstall/preflight_test.go | Tests mirror registry required actions list. |
| cli/internal/install/cloudinstall/installer.go | Adds installer-scoped mirroring state storage. |
| cli/internal/install/cloudinstall/helm.go | Implements mirroring (rewrite + import) and rendered manifest validation; updates built-in charts/images to be mirrorable. |
| cli/internal/install/cloudinstall/helm_test.go | Adds unit tests for mirror rewrite logic, chart targeting, manifest parsing/validation, and override behavior. |
| cli/internal/install/cloudinstall/acr.go | Adds ACR resolution/import helpers and Helm registry authentication via refresh token exchange. |
| cli/internal/install/cloudinstall/acr_test.go | Tests ACR refresh token exchange behavior and error handling. |
| cli/internal/install/cloudinstall/logs.go | Adds fallback one-shot log retrieval by label for post-failure diagnostics. |
| cli/internal/install/cloudinstall/compute.go | Includes mirror registry in ACR attach/detach paths; adds debug logging in cluster diffing; adjusts addon profile initialization. |
| cli/go.mod / cli/go.sum | Adds Azure Container Registry ARM SDK dependency. |
| NOTICE.txt / .notice-metadata.txt | Updates NOTICE metadata for the new dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
hansenms
approved these changes
Apr 28, 2026
Collaborator
hansenms
left a comment
There was a problem hiding this comment.
This is great. Thanks @johnstairs
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
naegelejd
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds optional ACR mirroring support for Azure cloud installs via
cloud.containerRegistryMirror.When configured, the installer mirrors Tyger’s required container images into the specified private Azure Container Registry, rewrites Helm values to pull from that registry, and validates rendered manifests so unmirrored image references are caught before install.
This feature is intended for cloud environments that require all images and artifacts to be hosted in a private container registry that can be scanned.
Details
ImportImagefor container images and OCI charts where possible.tyger/<source-registry>/<repo>to avoid collisions between registries.containerRegistryMirrorto config templates, sample configs, and cloud installation docs.