Refine stale VNet link removal logic to only delete links created by tyger#318
Merged
johnstairs merged 1 commit intomainfrom May 5, 2026
Merged
Conversation
johnstairs
changed the title
tyger
There was a problem hiding this comment.
Pull request overview
This PR makes private DNS zone reconciliation safer by refining the stale virtual network (VNet) link cleanup logic so that it only deletes links that were created by Tyger for the current environment (identified via the tyger-environment tag). This reduces the risk of the installer removing links that were created manually or by other tooling.
Changes:
- Updates a private endpoint creation log message to describe the target as a generic “resource” rather than specifically a storage account.
- Adds tag-based filtering to stale private DNS zone VNet link removal so only Tyger-owned links for the current environment are deleted.
- Expands inline documentation describing the safer stale-link removal behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hansenms
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes private DNS zone reconciliation safer when removing stale virtual network links.
Previously, stale VNet links were deleted whenever their destination VNet was no longer in the expected set. Now, the installer only deletes a stale VNet link if it has the Tyger environment tag (
tyger-environment) matching the current environment name. This avoids deleting links that were created manually or by another tool.